Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaEngine] Fix engine unit tests #1280

Merged
merged 9 commits into from Mar 26, 2020
Merged

[SofaEngine] Fix engine unit tests #1280

merged 9 commits into from Mar 26, 2020

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Mar 21, 2020 •
edited

Following #1237 , some error messages were not expected in some unit tests; triggering a FAILED status.
This PR fixes that, and add two more (real) unit tests for RandomPointDistributionInSurface and JoinPoints engines.
Moreover, it fixes also an example of the ExtrudeEngine scene and adds a example scene for RandomPointDistributionInSurface .

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Mar 21, 2020
@fredroy
Copy link
Contributor Author

fredroy commented Mar 21, 2020

[ci-build][force-full-build]

fredroy and others added 3 commits March 22, 2020 19:55
@fredroy
Fix compilation
8d922d4
@guparan
[SofaGeneralEngine_test] CLEAN indentation
6e969d3 
CLEAN RandomPointDistributionInSurface_test indentation
@guparan
[SofaGeneralEngine_test] CLEAN indentation (2)
d0e8fa3 
CLEAN JoinPoints_test indentation
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 25, 2020
@guparan guparan merged commit 4182de7 into sofa-framework:master Mar 26, 2020
@fredroy fredroy deleted the fix_engine_unittests branch April 26, 2020 13:02
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
@guparan guparan changed the title [Tests] Fix engine unit tests [SofaEngine] Fix engine unit tests Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fredroy @guparan @hugtalbot