[Changelog] Update Changelog with breaking changes #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with recent breaking PRs
hugtalbot
added
pr: fast merge
epernod
reviewed
Oct 26, 2020
| - [All] Uniform size type [#1515](https://github.com/sofa-framework/sofa/pull/1515) | ||
| - [All] Change index_type from size_t to uint [#1514](https://github.com/sofa-framework/sofa/pull/1514) | ||
| - [All] Standardize index type for Vector/Matrix templates [#1453](https://github.com/sofa-framework/sofa/pull/1453) | ||
| - Ongoing [cleaning of the Link implementation](https://github.com/sofa-framework/sofa/issues/1526) |
There was a problem hiding this comment.
I would break the breaking into 2 parts here:
- The big big breaking (sofa ng + size_t) and the usual breaking
|
|
||
| - Ongoing [SOFA-NG project](https://github.com/sofa-framework/sofa/issues/1527) generate several breaking changes due to modularization. It currently targets SOFA packages (SofaMisc, [SofaGeneral](https://github.com/sofa-framework/sofa/issues/1529) and soon SofaCommon), as well as SofaKernel (SofaBase\*, SofaCore, SofaHelper, SofaSimulation). Follow the [progress of the project online](https://github.com/sofa-framework/sofa/projects/9#card-47075575). | ||
| - [Modularization] SofaMisc* (Revival) [#1520](https://github.com/sofa-framework/sofa/pull/1520) |
There was a problem hiding this comment.
I would put a line before like:
Any cmake configuration error could come from PR Y
and before the size_t change: any compilation error link to type missmatch or unknow signature method could come from PR X
There was a problem hiding this comment.
thanks for the feedback @epernod
guparan
changed the title
hugtalbot
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ChangeLog to better guide users when facing issues with recent breaking PRs
This PR:
Reviewers will merge only if all these checks are true.