Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Set read-only all data defined by the file loaded #1660

Merged
merged 1 commit into from Dec 15, 2020
Merged

[SofaKernel] Set read-only all data defined by the file loaded #1660

merged 1 commit into from Dec 15, 2020

Conversation

hugtalbot
Copy link
Contributor

Just set all data defined by the loader as read-only since it makes no sense any user modifies them directly

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Dec 11, 2020
@hugtalbot
Copy link
Contributor Author

Nobody reviewed me 😢

@damienmarchal
Copy link
Contributor

Poor @hugtalbot, nobody reviewed you....so I did and it is ok for me.

@damienmarchal damienmarchal added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 15, 2020
@epernod epernod merged commit 7d33a62 into sofa-framework:master Dec 15, 2020
guparan pushed a commit that referenced this pull request Dec 17, 2020
@epernod @guparan
Merge pull request #1660 from hugtalbot/readonly_meshload_data_202012
2c76f57 
[SofaKernel] Set read-only all data defined by the file loaded
@guparan guparan added this to the v20.12 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienmarchal damienmarchal Awaiting requested review from damienmarchal

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hugtalbot @damienmarchal @guparan @epernod