New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaCore] Merge TData in Data. #1753
[SofaCore] Merge TData in Data. #1753
Conversation
[ci-build][with-all-tests] |
applications/plugins/Registration/ClosestPointRegistrationForceField.inl
Outdated
Show resolved
Hide resolved
Thanks you very much @epernod for the review. |
PR looks fine, but we absolutely need to define the convention about _doXXX_ or _isXXXX_ |
So ready, isn it :) |
So after discussion on gitter, the convention is If it is not private then feel free (which is exactly how is the sofa code base right now). |
Appart from that, I did a quick search in the sofa code base, I didn't paid attention to how much of the doXXXX stuff are with a public visibility... which is clearly not what the design pattern suggested initially. |
I don't know what exactly was TData for, but in years no-one ever use it so I merged Data & TData to make things more clear.
I also re-implemented the existing feature using the child-delegation pattern instead of relying on call super.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if