[SofaFramework] Create Sofa.Testing module #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: status to review
guparan
reviewed
Mar 3, 2021
CMakeLists.txt
Outdated
Comment on lines
190
to
194
| # add tests of previous projects, now that we have Sofa.Testing enabled | ||
| set(SOFAKERNEL_LIST_TARGET_UNITTESTS SofaHelper SofaDefaultType SofaCore SofaSimulationCore SofaSimulationGraph) | ||
| foreach(target ${SOFAKERNEL_LIST_TARGET_UNITTESTS}) | ||
| add_subdirectory(${SOFA_KERNEL_SOURCE_DIR}/modules/${target}/${target}_test) | ||
| endforeach() |
There was a problem hiding this comment.
SofaSimulationGraph_test is missing in tests/CMakeLists.txt though
hugtalbot
added
pr: status wip
fredroy
added
pr: status to review
|
[ci-build][force-full-build][with-all-tests] |
fredroy
added
NG1: include-graph
guparan
suggested changes
Mar 15, 2021
Comment on lines
-60
to
-66
|
|
||
| ## Tests | ||
| # cmake_dependent_option(SOFA_TYPE_BUILD_TESTS "Compile the automatic tests" ON "SOFA_BUILD_TESTS OR NOT DEFINED SOFA_BUILD_TESTS" OFF) | ||
| # if(SOFA_TYPE_BUILD_TESTS) | ||
| # enable_testing() | ||
| # add_subdirectory(${PROJECT_NAME}_test) | ||
| # endif() |
There was a problem hiding this comment.
Let's remove the whole Sofa.Type_test directory then 👍
Comment on lines
+5
to
+6
| GIT_REPOSITORY https://github.com/fredroy/SofaPython3 | ||
| GIT_TAG origin/follow_sofa_pr1834 |
There was a problem hiding this comment.
I see no PR on https://github.com/sofa-framework/SofaPython3 👀
There was a problem hiding this comment.
I was planning to create PR once everything compiles (and everything is OK) but why not yes
Comment on lines
+5
to
+6
| GIT_REPOSITORY https://github.com/fredroy/regression | ||
| GIT_TAG origin/follow_sofa_pr1834 |
There was a problem hiding this comment.
You can push your changes directly on https://github.com/sofa-framework/Regression and update GIT_TAG only 👍
There was a problem hiding this comment.
Ok i will push directly the branch in the sofa-framework repo from now on then
Co-authored-by: Guillaume Paran <guillaume.paran@sofa-framework.org>
|
[ci-build] |
|
[ci-build][force-full-build][with-all-tests] |
hugtalbot
added
pr: status ready
|
Related to #1827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DEMO]First step for an unified testing system.
This module gathers:
This module needs to be compiled AFTER SofaSimulation, as SofaGTestMain needs SofaSimulationGraph.
Unfortunately, there is still the mess with the plugin SofaTest, which needs to be solved as well.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if