Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaMiscCollision] Fix config.in cmake file for export #2052

Merged
merged 1 commit into from May 3, 2021
Merged

[SofaMiscCollision] Fix config.in cmake file for export #2052

merged 1 commit into from May 3, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Apr 29, 2021

SofaMiscCollisionConfig.cmake.in was ill-formed, so projects using it in out-of-tree builds are stuck in the cmake configuration process.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: backport todo This PR will be backported into the release preceeding its milestone. labels Apr 29, 2021
epernod
epernod approved these changes Apr 30, 2021
View reviewed changes
applications/plugins/SofaMiscCollision/SofaMiscCollisionConfig.cmake.in
@@ -3,6 +3,15 @@
@PACKAGE_GUARD@
@PACKAGE_INIT@

find_package(SofaBaseCollision QUIET REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does it means again QUIET and REQUIRED ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It tells to CMake "I need this package so you must fail if you can't find it (REQUIRED), but I don't want to see that you found it in the logs (QUIET)".

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 3, 2021
@guparan guparan merged commit f8deee0 into sofa-framework:master May 3, 2021
@guparan guparan added this to the v21.06 milestone May 7, 2021
guparan pushed a commit to guparan/sofa that referenced this pull request May 7, 2021
@fredroy @guparan
[SofaMiscCollision] Fix config.in cmake file for export (sofa-framewo…
93aa443 
…rk#2052)
@guparan guparan added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jul 9, 2021
@fredroy fredroy deleted the fix_misccollision_config branch October 14, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan left review comments

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fredroy @guparan @epernod