Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaCore] FIX BaseData::getLinkPath() #2354

Merged
merged 4 commits into from
Sep 27, 2021
Merged

[SofaCore] FIX BaseData::getLinkPath() #2354

merged 4 commits into from
Sep 27, 2021

Conversation

damienmarchal
Copy link
Contributor

The implementation was not correct.
BaseData::getLinkPath() should return a string pointing to the current data not the link value
of a parented data.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@damienmarchal
[SofaCore] Restore BaseData_test.cpp
f43f64a 
The test was not in CMakeLists.txt and thus not compiled.

This PR:
- add BaseData_test.cpp in CMakeLists.txt
- add the missing virtual functions in the test to make  it work again
- add a test to validate the behavior of getLinkName()
@damienmarchal
[SofaCore] Fix implementation of BaseData::getLinkPath()
233c0f1 
The implementation was not correct.
getLinkPath() should return a string pointing to the current data not the link value
of a parented data.
@damienmarchal
[SofaGuiQt] Fix the display of linked data field.
56d4fea 
Data fiedl with a parent are not displayed correctly in the GUI.
@damienmarchal damienmarchal added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Sep 22, 2021
@fredroy
Copy link
Contributor

fredroy commented Sep 23, 2021

[ci-build][with-all-tests]

@damienmarchal damienmarchal mentioned this pull request Sep 23, 2021
Merged
@fredroy
Copy link
Contributor

fredroy commented Sep 27, 2021

As SofaPython(2) has been dropped from the official support, the unit test UnitTests.SofaPython_test/PythonBinding/PythonBinding_tests.scene/2 wont be fixed.
If interested, have a look at https://github.com/sofa-framework/SofaPython/blob/6e0abe2c00ceffa627f992cdab7b826b07021f46/Binding_Data.cpp#L714

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 27, 2021
@fredroy fredroy merged commit f83c1ce into sofa-framework:master Sep 27, 2021
@fredroy fredroy mentioned this pull request Sep 27, 2021
Open
@guparan guparan added this to the v21.12 milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot left review comments

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damienmarchal @fredroy @hugtalbot @guparan