-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaBaseTopology][SofaDeformable][SofaMiscTopology] Proper topological changes in SpringForceField #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
pr: fix
Fix a bug
pr: status to review
To notify reviewers to review this pull-request
labels
Feb 2, 2022
[ci-build][with-all-tests] |
epernod
requested changes
Feb 7, 2022
SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/PointSetTopologyModifier.cpp
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaDeformable/src/SofaDeformable/SpringForceField.inl
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaDeformable/src/SofaDeformable/SpringForceField.h
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaDeformable/src/SofaDeformable/SpringForceField.h
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaDeformable/src/SofaDeformable/SpringForceField.inl
Outdated
Show resolved
Hide resolved
alxbilger
force-pushed
the
topochangepoints
branch
from
February 7, 2022 17:19
ca6508c
to
6f4c742
Compare
5 tasks
epernod
requested changes
Feb 11, 2022
modules/SofaMiscTopology/src/SofaMiscTopology/TopologicalChangeProcessor.cpp
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/PointSetTopologyModifier.h
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/PointSetTopologyModifier.cpp
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/PointSetTopologyModifier.cpp
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaDeformable/src/SofaDeformable/SpringForceField.inl
Outdated
Show resolved
Hide resolved
epernod
approved these changes
Feb 15, 2022
epernod
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpringForceField
is updated to handle topological changes properly. It now uses callbacks.A scene example is introduced to test topological changes on a
SpringForceField
. To make the example working, point removal was needed but not implemented. That is why I had to implementPointSetTopologyModifier::removeItems
, and added the support of points inTopologicalChangeProcessor
.The use of callbacks fixes the application of the topological changes in
SpringForceField
. Before the use of callbacks, the topological changes were not applied because the force field was not in the same Node than the topology.The new code also supports a change in both input topologies. Previously, changes only in the second topology were possible.
Without having testing it, I think the previous code did not handle properly multiple springs connected on a single DoF. This is now fixed.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if