Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaBaseTopology][SofaDeformable][SofaMiscTopology] Proper topological changes in SpringForceField #2653

Merged
merged 9 commits into from
Feb 17, 2022

Conversation

alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Feb 2, 2022

SpringForceField is updated to handle topological changes properly. It now uses callbacks.
A scene example is introduced to test topological changes on a SpringForceField. To make the example working, point removal was needed but not implemented. That is why I had to implement PointSetTopologyModifier::removeItems, and added the support of points in TopologicalChangeProcessor.

The use of callbacks fixes the application of the topological changes in SpringForceField. Before the use of callbacks, the topological changes were not applied because the force field was not in the same Node than the topology.

The new code also supports a change in both input topologies. Previously, changes only in the second topology were possible.

Without having testing it, I think the previous code did not handle properly multiple springs connected on a single DoF. This is now fixed.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Feb 2, 2022
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 15, 2022
@epernod epernod merged commit 208082e into sofa-framework:master Feb 17, 2022
@guparan guparan added this to the v22.06 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants