Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Constraint.Lagrangian] Make class abstract and add key function #3240

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Aug 24, 2022

Should fix a failing unit test: https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/master/CI_CONFIG=macos_clang,CI_PLUGINS=options,CI_TYPE=release/3799/testReport/UnitTests/

The dynamic_cast failed in:

py::cast(dynamic_cast<ConstraintSolverImpl*>(object));

This is due to the lack of key function in the class ConstraintSolverImpl

See
android/ndk#533 (comment)


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added the pr: status to review To notify reviewers to review this pull-request label Aug 24, 2022
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@alxbilger alxbilger added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Aug 24, 2022
@fredroy
Copy link
Contributor

fredroy commented Aug 25, 2022

I don't know how you found this but very well done !!! 👍

@damienmarchal damienmarchal added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 25, 2022
@damienmarchal damienmarchal merged commit 1237ab9 into sofa-framework:master Aug 25, 2022
@alxbilger
Copy link
Contributor Author

@sofa-framework/consortium-staff hotfix in 22.06?

@alxbilger alxbilger added the pr: backport todo This PR will be backported into the release preceeding its milestone. label Aug 29, 2022
@hugtalbot hugtalbot removed the pr: backport todo This PR will be backported into the release preceeding its milestone. label Aug 31, 2022
@guparan guparan added this to the v22.12 milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants