[all] Add DeprecatedData and RemovedData #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmarchal
added
the
pr: status to review
alxbilger
changed the title
fredroy
requested changes
Jun 13, 2023
Sofa/framework/Core/src/sofa/core/objectmodel/DeprecatedData.cpp
Outdated
Show resolved
Hide resolved
hugtalbot
added
enhancement
damienmarchal
added
pr: status to review
|
[ci-build][with-tests] |
|
[ci-build][with-all-tests] |
fredroy
requested changes
Jun 19, 2023
...s/MultiThreading/src/MultiThreading/component/animationloop/AnimationLoopParallelScheduler.h
Outdated
Show resolved
Hide resolved
...s/MultiThreading/src/MultiThreading/component/animationloop/AnimationLoopParallelScheduler.h
Outdated
Show resolved
Hide resolved
hugtalbot
reviewed
Jun 21, 2023
alxbilger
requested changes
Jun 21, 2023
|
2 tests are considered as failing since the message of RemovedData is thrown as an |
Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
damienmarchal
removed
the
pr: status to review
Signed-off-by: Damien Marchal <damien.marchal@univ-lille1.fr>
damienmarchal
added
the
pr: status to review
fredroy
approved these changes
Jun 27, 2023
|
[ci-build][with-all-tests] |
fredroy
added
pr: status ready
damienmarchal
added a commit
to CRIStAL-PADR/sofa
that referenced
this pull request
Jun 28, 2023
* WIP * Generalize the use of RemoveData instead of overriding parse() * FIXUP * FIXUP: Add SOFA_CORE_API * WIp * Update Sofa/framework/Core/src/sofa/core/objectmodel/RemovedData.h Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com> * Update Sofa/framework/Core/src/sofa/core/objectmodel/DeprecatedData.h Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com> * Fix broken indentation * Replace the deprecated "numberThread" with nbThreads Signed-off-by: Damien Marchal <damien.marchal@univ-lille1.fr> --------- Signed-off-by: Damien Marchal <damien.marchal@univ-lille1.fr> Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it more simple to manage deprecation and more specifically to not override the parse() method for that purpose.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if