Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libQGLViewer] FIX missing headers #461

Merged
merged 1 commit into from Oct 16, 2017
Merged

[libQGLViewer] FIX missing headers #461

merged 1 commit into from Oct 16, 2017

Conversation

gKevin
Copy link
Contributor

@gKevin gKevin commented Oct 10, 2017

We ran into some more compile errors on windows using MSVC 2015.

libQGLViewer wouldn't compile without those missing headers.

Here's a quick fix but you might want to update libQGLViewer to the latest version (2.7.0).


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@sofabot
Copy link
Collaborator

sofabot commented Oct 10, 2017

Thank you for your pull request!
Someone will soon check it and start the builds.

@damienmarchal damienmarchal added the pr: fix Fix a bug label Oct 10, 2017
@guparan guparan added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Oct 11, 2017
@guparan
Copy link
Contributor

guparan commented Oct 11, 2017

Thanks @gKevin. I set this PR as fast-merge.
[ci-build]

@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Oct 12, 2017
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 16, 2017
@guparan guparan merged commit 3bef544 into sofa-framework:master Oct 16, 2017
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants