Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI.Qt] Some cleaning in qt RealGui #4641

Merged
merged 5 commits into from Apr 18, 2024
Merged

[GUI.Qt] Some cleaning in qt RealGui #4641

merged 5 commits into from Apr 18, 2024

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Apr 9, 2024 •
edited

continue porting old changes from branch https://github.com/epernod/sofa/pull/13/files

Some cleaning in Qt Gui:

  • Rome old options not used? like m_isEmbeddedViewer or m_createViewersOpt
  • Store SofaViewer* directly to avoid multiple dynamic casts

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Apr 9, 2024
@epernod epernod mentioned this pull request Apr 10, 2024
Open
hugtalbot
hugtalbot approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@hugtalbot hugtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but someone more expert in GUI than I am would be good
Maybe @fredroy

fredroy
fredroy requested changes Apr 11, 2024
View reviewed changes
Sofa/GUI/Qt/src/sofa/gui/qt/RealGUI.cpp Outdated Show resolved Hide resolved
Sofa/GUI/Qt/src/sofa/gui/qt/RealGUI.cpp Outdated Show resolved Hide resolved
Sofa/GUI/Qt/src/sofa/gui/qt/RealGUI.cpp Outdated Show resolved Hide resolved
Sofa/GUI/Qt/src/sofa/gui/qt/RealGUI.cpp Outdated Show resolved Hide resolved
@epernod
Copy link
Contributor Author

epernod commented Apr 11, 2024

[ci-build][with-all-tests]

@hugtalbot hugtalbot changed the title [QtGui] Some cleaning in qt RealGui [GUI.Qt] Some cleaning in qt RealGui Apr 17, 2024
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 17, 2024
fredroy
fredroy reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added breaking because of type change and methods deletion

@fredroy fredroy added the pr: breaking Change possibly inducing a compilation error label Apr 18, 2024
@fredroy fredroy merged commit 7ac489f into sofa-framework:master Apr 18, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy approved these changes

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@epernod @fredroy @hugtalbot