Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove warning generated by MapMapSparseMatrixEigenUtils #485

Merged
merged 1 commit into from Oct 23, 2017
Merged

remove warning generated by MapMapSparseMatrixEigenUtils #485

merged 1 commit into from Oct 23, 2017

Conversation

ErwanDouaille
Copy link
Contributor

@ErwanDouaille ErwanDouaille commented Oct 20, 2017 •
edited by guparan

Remove new warning in MapMapSparseMatrixEigenUtils.h

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@ErwanDouaille ErwanDouaille added pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Oct 20, 2017
@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Oct 20, 2017
@guparan
Copy link
Contributor

guparan commented Oct 23, 2017

thanks @ErwanDouaille
What were the warnings? unused values?

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 23, 2017
@ErwanDouaille
Copy link
Contributor Author

ErwanDouaille commented Oct 23, 2017 •
edited

@guparan yes, unused values

@guparan
Copy link
Contributor

guparan commented Oct 23, 2017

I merge this right now to be able to remove the branch from sofa-framework.

@guparan guparan merged commit 0ffcd22 into master Oct 23, 2017
@guparan guparan deleted the warningRemovalMapMapSparseMatrixEigenUtils branch October 23, 2017 13:04
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ErwanDouaille @guparan @hugtalbot