[CMake] Cleans for packaging #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should prefer SofaFramework_VERSION which refers directly to the target, instead of a cached variable.
guparan
added
pr: status to review
untereiner
reviewed
Oct 1, 2018
| string(REGEX REPLACE "\\/[^/]*/[^/]*$" "" Qt_location ${QtCore_location}) | ||
| FILE(GLOB QT_PLUGINS "${Qt_location}/plugins/platforms/qwindows*.dll") | ||
| install(FILES ${QT_PLUGINS} DESTINATION "bin/platforms" COMPONENT applications) | ||
| # QT INSTALL |
There was a problem hiding this comment.
pour une install des libs qt un peu moins dirty: https://github.com/cgogn/SCHNApps/blob/develop/schnapps/CMakeLists.txt
ps: j'ai qu'une target windows, faudrait faire la même pour mac
There was a problem hiding this comment.
On my TODO list for a long long time...
guparan
added
the
pr: backport done
|
[ci-build][with-scene-tests] |
guparan
added
pr: status ready
guparan
added a commit
to guparan/sofa
that referenced
this pull request
Oct 4, 2018
[CMake] Cleans for packaging # Conflicts: # CMakeLists.txt # SofaKernel/SofaFramework/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of CMake changes I made for v18.06 construction.
This PR:
Reviewers will merge only if all these checks are true.