[SofaBaseMechanics] BarycentricMapping: spatial hashing, handle limit cases #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lls with same h index
…ement in the grid cell is far (and minor cleaning and refactoring)
hugtalbot
added
the
pr: status to review
EulalieCoevoet
added
pr: status wip
EulalieCoevoet
added
pr: status to review
|
[ci-build] [with-scene-tests] [with-regression-tests] |
epernod
reviewed
Jan 22, 2019
SofaKernel/modules/SofaBaseMechanics/BarycentricMappers/BarycentricMapperTopologyContainer.h
Show resolved
Hide resolved
SofaKernel/modules/SofaBaseMechanics/BarycentricMappers/BarycentricMapperTopologyContainer.inl
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaBaseMechanics/BarycentricMappers/BarycentricMapperTopologyContainer.inl
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaBaseMechanics/BarycentricMappers/BarycentricMapperTopologyContainer.inl
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaBaseMechanics/SofaBaseMechanics_test/BarycentricMapping_test.cpp
Show resolved
Hide resolved
guparan
added
pr: status wip
tgaugry
reviewed
Jan 23, 2019
SofaKernel/modules/SofaBaseMechanics/BarycentricMappers/BarycentricMapperTopologyContainer.h
Outdated
Show resolved
Hide resolved
tgaugry
reviewed
Jan 23, 2019
SofaKernel/modules/SofaBaseMechanics/BarycentricMappers/BarycentricMapperTopologyContainer.h
Outdated
Show resolved
Hide resolved
damienmarchal
added
pr: status to review
guparan
added
pr: status ready
|
Many thanks Eulalie for this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR follows the changes made in BarycentricMapping (i.e use of spatial hashing to find the nearest points instead of an exhaustive search). This new PR:
Handle cases of several grid cells having the same h index. In such case, the distance between two points, that have the same h index, should be computed only if the points are in the same grid cell. This PR add this implementation. Each element is now stored in the hash table with its corresponding grid cell indices.
The nearest point, in a shared grid cell, may not be the global nearest point. To improve that, we detect when neighboring cells may contain a better solution, and do the check. These additional computations are still far better than the exhaustive search.
This PR:
Reviewers will merge only if all these checks are true.