Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaCore] Collision visitor primitive tests count #930

Merged
merged 4 commits into from Feb 26, 2019
Merged

[SofaCore] Collision visitor primitive tests count #930

merged 4 commits into from Feb 26, 2019

Conversation

fspadoni
Copy link
Contributor

@fspadoni fspadoni commented Feb 12, 2019 •
edited by damienmarchal

Add a variable to count the number of primitve tests performed during the narrow phase of the collision detection.
This variable is only for statistics purpose

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fspadoni fspadoni added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Feb 13, 2019
@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Feb 20, 2019
@fspadoni fspadoni added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Feb 21, 2019
@damienmarchal damienmarchal added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 26, 2019
@damienmarchal
Copy link
Contributor

Ready... will be merged in 10 minutes :)

@damienmarchal damienmarchal reopened this Feb 26, 2019
@damienmarchal damienmarchal merged commit 779336d into sofa-framework:master Feb 26, 2019
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
@guparan guparan changed the title [CollisionVisitor] primitive tests count [SofaCore] Collision visitor primitive tests count Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fspadoni @damienmarchal @guparan