Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SOFAresample function #55

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

davircarvalho
Copy link
Contributor

adds resampling function for SimpleFreeFieldHRIR and demo code

@isfmiho
Copy link
Collaborator

isfmiho commented Sep 27, 2022

Thank you Davi, can I set both files to EUPL license?

I would adapt the headers as well, to keep a consistent format.

@davircarvalho
Copy link
Contributor Author

Sure sure I forgot to include it, feel free to modify before accepting the pull request

@isfmiho isfmiho merged commit 8a781cb into sofacoustics:master Sep 29, 2022
@isfmiho isfmiho mentioned this pull request Sep 29, 2022
@petibub
Copy link
Member

petibub commented Sep 29, 2022

Hi David, thanks for providing SOFAresample. Works like a charm!
A question: why did you include the post-hoc filtering? This makes SOFAresample to SOFAresampleAndFilter somehow...
Can we remove the filtering such that potential users do that filtering post hoc by themselves? Or, do you use it widely in your applications (then, I'd prefer to have the filtering selected by a flag)?

@davircarvalho
Copy link
Contributor Author

@petibub this is how I normally use this function, my thought in leaving the filtering was to avoid undesirable artefacts for less experienced users and students. I agree it makes sense to leave it as an optional flag though

@petibub
Copy link
Member

petibub commented Sep 30, 2022

Ah, I understand. What that be OK to have flags 'scale', 'noscale', 'filter', 'nofilter' with 'scale' and 'nofilter' as defaults?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants