-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add log for file not found #874
Conversation
WalkthroughThe update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- sofa-ark-parent/core-impl/archive/src/main/java/com/alipay/sofa/ark/loader/data/RandomAccessDataFile.java (1 hunks)
Additional comments: 1
sofa-ark-parent/core-impl/archive/src/main/java/com/alipay/sofa/ark/loader/data/RandomAccessDataFile.java (1)
- 67-67: The enhancement to include the file path in the exception message when a file does not exist is a valuable improvement for error diagnostics. This change should make it easier for developers and system administrators to identify and troubleshoot file-related issues.
However, for consistency, consider using a more descriptive message that also suggests the expected action or the reason why the file must exist. For example, "The specified file does not exist: %s. Please ensure the file path is correct and the file is accessible."
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #874 +/- ##
============================================
+ Coverage 78.76% 78.92% +0.16%
+ Complexity 835 834 -1
============================================
Files 162 162
Lines 6794 6794
Branches 1011 1011
============================================
+ Hits 5351 5362 +11
+ Misses 921 910 -11
Partials 522 522 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit