-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsynMultiInterestUserProcessor在执行时被当做SyncUserProcessor #157
Comments
@adisby 能否提供一个复现以上问题的testcase |
I can replay it. when client call the server,the client side get the error stack: it obviously a bug,I will try to fix it。 |
…uest method problem. sofastackgh-157" This reverts commit 2784f9e.
@lollapalooza1989 welcome PR to help us fix it. |
* fix AbstractLifeCycle concurrency problem Fixes gh-163 * fix AbstractLifeCycle concurrency problem Fixes gh-163 * fix AsynMultiInterestUserProcessor dispatch to sync handleRequest method problem. gh-157 * Revert "fix AsynMultiInterestUserProcessor dispatch to sync handleRequest method problem. gh-157" This reverts commit 2784f9e.
* fix AbstractLifeCycle concurrency problem Fixes gh-163 (#188) * fix AsynMultiInterestUserProcessor dispatch to sync handleRequest method problem. gh-157 * Revert "fix AsynMultiInterestUserProcessor dispatch to sync handleRequest method problem. gh-157" This reverts commit 2784f9e. * support server random port constructor
* (feat) add flush consolidation handler (#161) * (feat) add flush consolidation option * 1. upgrade version to 1.5.6 (#169) 2. fix NPE in channelInactive 3. handling reconnection situation with no connection binding with channel 4. du not scan connection pool associated with task that has not been don 5. add CONNECT_FAILED event type and print user event log * Change org from alipay to sofatack. (#172) * Update .travis.yml (#177) * modify ReconnectManager to be compatible with version 1.5.x * upgrade netty version to fix CNNVD-201909-1264 vulnerability (#189) * 应该一个是序列化一个是反序列化 (#191) fix unit test bug in class NormalStringCustomSerializer. * (feat) Supports SSL for rpc server/client, #149 (#197) * support server random port constructor. fix #196 (#199) * fix AbstractLifeCycle concurrency problem Fixes gh-163 (#188) * fix AsynMultiInterestUserProcessor dispatch to sync handleRequest method problem. gh-157 * Revert "fix AsynMultiInterestUserProcessor dispatch to sync handleRequest method problem. gh-157" This reverts commit 2784f9e. * support server random port constructor * add rejection-processable InvokeCallback to provide flexible options when user executor rejected task. see #178(#178) (#202) * complete tcp related config. see #171(#171) (#205) * optimize DefaultConnectionManager contructor (#201) * support availability check with life cycle. #195 (#204) * support availability check with life cycle. #123(#123) * complete unit test of life cycle available check * fix CI error * Fix/multi processor bug (#207) * fix spell mistake and some test codes (#194) * fix multi-processor bug * fix PMD * support user processor with life cycle interface fix #123 (#200) * support user processor with life cycle interface * make sure user processor startup if client/server has startup * add state check before operate user processor in order to prevent from some unnecessary exception * fix some codes (#208) * change version
* release 1.6.1 (#209) * (feat) add flush consolidation handler (#161) * (feat) add flush consolidation option * 1. upgrade version to 1.5.6 (#169) 2. fix NPE in channelInactive 3. handling reconnection situation with no connection binding with channel 4. du not scan connection pool associated with task that has not been don 5. add CONNECT_FAILED event type and print user event log * Change org from alipay to sofatack. (#172) * Update .travis.yml (#177) * modify ReconnectManager to be compatible with version 1.5.x * upgrade netty version to fix CNNVD-201909-1264 vulnerability (#189) * 应该一个是序列化一个是反序列化 (#191) fix unit test bug in class NormalStringCustomSerializer. * (feat) Supports SSL for rpc server/client, #149 (#197) * support server random port constructor. fix #196 (#199) * fix AbstractLifeCycle concurrency problem Fixes gh-163 (#188) * fix AsynMultiInterestUserProcessor dispatch to sync handleRequest method problem. gh-157 * Revert "fix AsynMultiInterestUserProcessor dispatch to sync handleRequest method problem. gh-157" This reverts commit 2784f9e. * support server random port constructor * add rejection-processable InvokeCallback to provide flexible options when user executor rejected task. see #178(#178) (#202) * complete tcp related config. see #171(#171) (#205) * optimize DefaultConnectionManager contructor (#201) * support availability check with life cycle. #195 (#204) * support availability check with life cycle. #123(#123) * complete unit test of life cycle available check * fix CI error * Fix/multi processor bug (#207) * fix spell mistake and some test codes (#194) * fix multi-processor bug * fix PMD * support user processor with life cycle interface fix #123 (#200) * support user processor with life cycle interface * make sure user processor startup if client/server has startup * add state check before operate user processor in order to prevent from some unnecessary exception * fix some codes (#208) * change version * update travis ci config Co-authored-by: cytnju <muyun.cyt@antfin.com>
Describe the bug
由于AsynMultiInterestUserProcessor不是AsyncUserProcessor的子类,所以在RpcRequestProcessor.dispatchToUserProcessor()方法中被当做了SyncUserProcessor执行并同步等待,最终抛出异常
https://github.com/alipay/sofa-bolt/blob/531d1c0d872553d92fc55775565b3f7be8661afa/src/main/java/com/alipay/remoting/rpc/protocol/RpcRequestProcessor.java#L222
Expected behavior
AsynMultiInterestUserProcessor所注册的业务会异步处理
Actual behavior
AsynMultiInterestUserProcessor所注册的业务被当做SyncUserProcessor并且执行时抛出异常
Steps to reproduce
Minimal yet complete reproducer code (or GitHub URL to code)
Environment
SOFABolt version: 1.5.3
JVM version (e.g.
java -version
): 1.8.0_161OS version (e.g.
uname -a
):Maven version:
IDE version:
The text was updated successfully, but these errors were encountered: