When configure management.port，readiness/runtime health check result may return success in app startup process

[straybirdzls]

Configure management.port=8081 , then in app startup process， when access http://localhost:8081/health or http://localhost:8081/health/readiness will get 200, which means app already start up success.

The reason : 8081 is opened before app startup finish. Port 8081 is open by org.springframework.boot.actuate.autoconfigure.EndpointWebMvcAutoConfiguration after root application initialize all beans(before ContextRefreshedEvent)

Override
public void afterSingletonsInstantiated() {
    ManagementServerPort managementPort = ManagementServerPort.DIFFERENT;
    if (this.applicationContext instanceof WebApplicationContext) {
        managementPort = ManagementServerPort
                .get(this.applicationContext.getEnvironment(), this.beanFactory);
    }
    if (managementPort == ManagementServerPort.DIFFERENT) {
        if (this.applicationContext instanceof EmbeddedWebApplicationContext
                && ((EmbeddedWebApplicationContext) this.applicationContext)
                        .getEmbeddedServletContainer() != null) {
            createChildManagementContext();
        }
        else {
            logger.warn("Could not start embedded management container on "
                    + "different port (management endpoints are still available "
                    + "through JMX)");
        }
    }
    if (managementPort == ManagementServerPort.SAME) {
        if (new RelaxedPropertyResolver(this.applicationContext.getEnvironment(),
                "management.ssl.").getProperty("enabled") != null) {
            throw new IllegalStateException(
                    "Management-specific SSL cannot be configured as the management "
                            + "server is not listening on a separate port");
        }
        if (this.applicationContext
                .getEnvironment() instanceof ConfigurableEnvironment) {
            addLocalManagementPortPropertyAlias(
                    (ConfigurableEnvironment) this.applicationContext
                            .getEnvironment());
        }
    }
}

However readiness healthcheck is done after ContextRefreshedEvent , and in isle scenario , all sofaboot modules are refreshed after ContextRefreshedEvent .

The early result 200 may cause serious problems on production.