Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick health check management fix from 2.6.0 #356

Merged
merged 3 commits into from
Feb 22, 2019
Merged

cherry pick health check management fix from 2.6.0 #356

merged 3 commits into from
Feb 22, 2019

Conversation

straybirdzls
Copy link
Member

cherry-pick for #313

@straybirdzls straybirdzls added this to the 3.1.2 milestone Jan 31, 2019
@codecov
Copy link

codecov bot commented Jan 31, 2019 •
edited
Loading

Codecov Report

Merging #356 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   66.59%   66.56%   -0.03%     
==========================================
  Files         130      130              
  Lines        3739     3739              
  Branches      511      511              
==========================================
- Hits         2490     2489       -1     
- Misses        958      960       +2     
+ Partials      291      290       -1
Impacted Files Coverage Δ
...spring/health/MultiApplicationHealthIndicator.java 18.75% <0%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b0201...204a2ce. Read the comment docs.

@straybirdzls straybirdzls changed the title cherry pick health check management fix cherry pick health check management fix from 2.6.0 Jan 31, 2019
glmapper
glmapper approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@QilongZhang QilongZhang merged commit c183e98 into sofastack:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjboy ujjboy ujjboy approved these changes

@QilongZhang QilongZhang QilongZhang approved these changes

@glmapper glmapper glmapper approved these changes

@caojie09 caojie09 Awaiting requested review from caojie09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@straybirdzls @ujjboy @QilongZhang @glmapper