Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure threadlocal object remove after use #1225

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1225 (a66d9f8) into 3.x (b8593ea) will increase coverage by 0.19%.
Report is 1 commits behind head on 3.x.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##                3.x    #1225      +/-   ##
============================================
+ Coverage     71.64%   71.83%   +0.19%     
- Complexity     1855     1865      +10     
============================================
  Files           260      260              
  Lines          7462     7470       +8     
  Branches        944      943       -1     
============================================
+ Hits           5346     5366      +20     
+ Misses         1636     1624      -12     
  Partials        480      480              
Files Changed Coverage Δ
...ay/sofa/boot/compatibility/VerificationResult.java 71.42% <76.92%> (+2.19%) ⬆️
...m/alipay/sofa/isle/stage/ModuleLogOutputStage.java 95.00% <100.00%> (+5.12%) ⬆️
.../sofa/runtime/factory/BeanLoadCostBeanFactory.java 74.15% <100.00%> (+0.59%) ⬆️
...a/runtime/invoke/DynamicJvmServiceProxyFinder.java 38.02% <100.00%> (-0.41%) ⬇️
...boot/compatibility/AbstractJarVersionVerifier.java 81.81% <100.00%> (ø)
...ot/compatibility/CompatibilityNotMetException.java 100.00% <100.00%> (ø)
.../compatibility/CompositeCompatibilityVerifier.java 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@taobaorun taobaorun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 9c9a0b9 into sofastack:3.x Aug 11, 2023
5 checks passed
@HzjNeverStop HzjNeverStop deleted the remove_threadlocal branch August 16, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants