Skip serialization of jvm invocation in ark #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongZhang
requested review from
caojie09,
ujjboy,
glmapper and
straybirdzls
and removed request for
caojie09
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
=========================================
+ Coverage 66.56% 68.5% +1.93%
=========================================
Files 130 132 +2
Lines 3739 3801 +62
Branches 511 514 +3
=========================================
+ Hits 2489 2604 +115
+ Misses 960 901 -59
- Partials 290 296 +6
Continue to review full report at Codecov.
|
straybirdzls
reviewed
Mar 7, 2019
| } finally { | ||
| pushThreadContextClassLoader(tcl); | ||
| } | ||
| } else if (TOSTRING_METHOD.equalsIgnoreCase(targetMethod.getName()) |
ujjboy
reviewed
Mar 7, 2019
| @@ -127,6 +127,10 @@ | |||
| <xsd:attribute name="registry" type="xsd:string" use="optional"/> | |||
| <xsd:attribute name="serialize-type" type="xsd:string" use="optional"/> | |||
| </xsd:complexType> | |||
| <!-- binding.jvm im reference --> | |||
| <xsd:complexType name="BBindingJvmReference"> | |||
| <xsd:attribute name="serialize" type="xsd:boolean" default="false" use="optional"/> | |||
There was a problem hiding this comment.
reference 默认不走序列化，service 默认走序列化. 只有两者都为 false 是，才会走直接调用模式。
服务端如果设置不走序列化，需要将相关类导出，而客户端无需变更代码。
只有当引用服务的应用配置了 deny-import 相关类，此时，客户端可能需要强制设置走序列化方式.
caojie09
reviewed
Mar 8, 2019
| @@ -127,6 +127,10 @@ | |||
| <xsd:attribute name="registry" type="xsd:string" use="optional"/> | |||
| <xsd:attribute name="serialize-type" type="xsd:string" use="optional"/> | |||
| </xsd:complexType> | |||
| <!-- binding.jvm im reference --> | |||
caojie09
reviewed
Mar 8, 2019
| @@ -33,8 +33,18 @@ | |||
| */ | |||
| public static BindingType JVM_BINDING_TYPE = new BindingType("jvm"); | |||
There was a problem hiding this comment.
这里的 "jvm" 字符串也换成下面的 XmlConstants 常量吧。
…-boot into skip_jvm_hessian_in_ark
straybirdzls
approved these changes
Mar 8, 2019
caojie09
approved these changes
Mar 8, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#369