Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metadata to Node on DiscoveryRequest #769

Open
kevin21th opened this issue Aug 8, 2019 · 0 comments
Open

add metadata to Node on DiscoveryRequest #769

kevin21th opened this issue Aug 8, 2019 · 0 comments
Assignees
@kevin21th
Labels
area/xds kind/feature new feature priority/P0 MUST fix ASAP

Comments

@kevin21th
Copy link
Contributor

The New Feature

add metadata to Node on DiscoveryRequest

Your scenes

mosn should translate some metadata to pilot, for example version of mosn. And then pilot could turn on new features for mosn witch can handle it

Your advice

add metadata field to Node on DiscoveryRequest like this:
envoy_api_v2.DiscoveryRequest{
Node: &envoy_api_v2_core1.Node{
Id: c.ServiceNode,
Cluster: c.ServiceCluster,
Metadata: c.Metadata,
},
}

Environment

  • SOFAMosn Version
@kevin21th kevin21th added kind/feature new feature priority/P0 MUST fix ASAP area/xds labels Aug 8, 2019
@kevin21th kevin21th self-assigned this Aug 8, 2019
kevin21th added a commit that referenced this issue Aug 8, 2019
@kevin21th
feature #769
dbd1774 
add metadata to Node on DiscoveryRequest
@kevin21th kevin21th mentioned this issue Aug 8, 2019
Merged
kevin21th added a commit that referenced this issue Aug 12, 2019
@kevin21th
Close Feature #769
6704ac7 
add globalXdsConfig and remove ClientV2
nejisama added a commit that referenced this issue Aug 13, 2019
@nejisama
Merge pull request #770 from sofastack/feature/add-metadata-to-node
9ce63cc 
close feature #769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin21th kevin21th

Labels
area/xds kind/feature new feature priority/P0 MUST fix ASAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevin21th