-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add log #1152
Feat/add log #1152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any test cases for this PR?
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
done |
Codecov Report
@@ Coverage Diff @@
## master #1152 +/- ##
============================================
+ Coverage 71.03% 71.06% +0.02%
- Complexity 827 828 +1
============================================
Files 406 406
Lines 17132 17150 +18
Branches 2670 2671 +1
============================================
+ Hits 12170 12187 +17
- Misses 3587 3588 +1
Partials 1375 1375
Continue to review full report at Codecov.
|
add log for serialize exception