Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add log #1152

Merged
merged 7 commits into from
Jan 10, 2022
Merged

Feat/add log #1152

merged 7 commits into from
Jan 10, 2022

Conversation

chuailiwu
Copy link
Collaborator

add log for serialize exception

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test cases for this PR?

@sofastack-bot sofastack-bot bot added size/M and removed size/S labels Dec 29, 2021
@chuailiwu
Copy link
Collaborator Author

Any test cases for this PR?

Added

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj
Copy link
Collaborator

EvenLjj commented Jan 10, 2022

image
@chuailiwu Please run mvn clean compile -DskipTests before you commit code, this will format the code.

@sofastack-bot sofastack-bot bot added size/L and removed size/M labels Jan 10, 2022
@chuailiwu
Copy link
Collaborator Author

done

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #1152 (b18f730) into master (07ab43b) will increase coverage by 0.02%.
The diff coverage is 70.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1152      +/-   ##
============================================
+ Coverage     71.03%   71.06%   +0.02%     
- Complexity      827      828       +1     
============================================
  Files           406      406              
  Lines         17132    17150      +18     
  Branches       2670     2671       +1     
============================================
+ Hits          12170    12187      +17     
- Misses         3587     3588       +1     
  Partials       1375     1375              
Impacted Files Coverage Δ
...ipay/sofa/rpc/codec/bolt/SofaRpcSerialization.java 76.01% <70.83%> (+2.10%) ⬆️
...ava/com/alipay/sofa/rpc/common/MetadataHolder.java 0.00% <0.00%> (-90.00%) ⬇️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 64.86% <0.00%> (-4.73%) ⬇️
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 90.32% <0.00%> (-0.75%) ⬇️
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 69.37% <0.00%> (-0.27%) ⬇️
...in/java/com/alipay/sofa/rpc/common/RpcConfigs.java 77.16% <0.00%> (ø)
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 84.90% <0.00%> (ø)
...ipay/sofa/rpc/common/struct/OrderedComparator.java 100.00% <0.00%> (ø)
...ay/sofa/rpc/filter/ConsumerCustomHeaderFilter.java 100.00% <0.00%> (ø)
...y/sofa/rpc/filter/PressureMarkTransformFilter.java 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ab43b...b18f730. Read the comment docs.

@EvenLjj EvenLjj added this to the 5.8.3 milestone Jan 10, 2022
@EvenLjj EvenLjj merged commit 956a546 into master Jan 10, 2022
@nobodyiam nobodyiam deleted the feat/addLog branch January 14, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants