-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: let use of javassist compatible both under java 17 and java 1.8 #1316
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1316 +/- ##
============================================
+ Coverage 72.02% 72.05% +0.02%
+ Complexity 786 784 -2
============================================
Files 415 415
Lines 17651 17653 +2
Branches 2753 2753
============================================
+ Hits 12714 12720 +6
+ Misses 3536 3532 -4
Partials 1401 1401
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Modify the parsing header method to facilitate expansion (#1325) Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> * feat: let use of javassist compatible at jdk 17 (#1316) Co-authored-by: junyuan <zhangminglun.zml@ant-group.com> * upgrade rpc version to 5.10.0-SNAPSHOT (#1326) * upgrade rpc version to 5.10.0-SNAPSHOT * upgrade rpc version to 5.10.0-SNAPSHOT --------- Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> * Custom serializer register (#1296) * feat: use extension on serializer register --------- Co-authored-by: 均源 <zhangminglun.zml@antgroup.com> Co-authored-by: junyuan <zhangminglun.zml@ant-group.com> * chore: update version to release (#1328) Co-authored-by: lo1nt <zhangminglun.zml@ant-group.com> * upgrade rpc version to 5.10.1-SNAPSHOT (#1334) Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> * support change grpc maxInboundMessageSize (#1333) Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> * Fix the unit test message too large problem (#1339) * support change grpc maxInboundMessageSize * fix the debug body message too large problem --------- Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> * feat: bump hessian from 3.13.3 to 3.4.0 (#1338) Co-authored-by: Lo1nt <zhangminglun.zml@antgroup.com> * updapte 5.10.1 version to release (#1337) Co-authored-by: Lo1nt <zhangminglun.zml@antgroup.com> * update version * bump hessian * update version * add ci * set verison as 51100 * fix: destory * fix: unit test --------- Co-authored-by: evenliu <evenljj@163.com> Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> Co-authored-by: lo1nt <zhangminglun.zml@ant-group.com> Co-authored-by: lo1nt <zhangminglun.zml@antgroup.com>
Motivation:
Running com.alipay.sofa.rpc.proxy.javassist.JavassistProxyTest encounters error under jdk 17
For java 11+, if no
neighbour
params passed toClassPool.toClass
, thejavassist.util.proxy.DefineClassHelper
would make a reflection call tojava.lang.ClassLoader.DefineClass
, which is, however, inaccessbile from unnamed module under java 17.Modification:
Use
javassist.ClassPool#toClass(javassist.CtClass, java.lang.Class<?>, java.lang.ClassLoader, java.security.ProtectionDomain)
instead ofjavassist.CtClass#toClass()
.Result:
com.alipay.sofa.rpc.proxy.javassist.JavassistProxyTest works both under java 17 and java 1.8.