Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support change grpc maxInboundMessageSize #1333

Merged

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Jun 6, 2023

support change grpc maxInboundMessageSize

@sofastack-cla sofastack-cla bot added cla:yes CLA is ok size/XS labels Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1333 (8c4e696) into master (bf8a17d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 8c4e696 differs from pull request most recent head 2a764b5. Consider uploading reports for the commit 2a764b5 to get more accurate results

@@             Coverage Diff              @@
##             master    #1333      +/-   ##
============================================
+ Coverage     71.98%   72.02%   +0.04%     
  Complexity      784      784              
============================================
  Files           416      416              
  Lines         17659    17660       +1     
  Branches       2752     2752              
============================================
+ Hits          12711    12720       +9     
+ Misses         3547     3539       -8     
  Partials       1401     1401              
Impacted Files Coverage Δ
...in/java/com/alipay/sofa/rpc/common/RpcOptions.java 100.00% <ø> (ø)
...fa/rpc/transport/triple/TripleClientTransport.java 71.07% <100.00%> (+0.24%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should both change outbound size.

@EvenLjj EvenLjj force-pushed the support_chanage_grpc_maxInboundMessageSize branch from 29ffc92 to 0ab4cb9 Compare June 7, 2023 02:22
@EvenLjj EvenLjj requested a review from OrezzerO June 7, 2023 02:27
@OrezzerO
Copy link
Contributor

OrezzerO commented Jun 7, 2023

  1. Test is needed to check the limited size.
  2. Do we need to set outbound size ?
    @EvenLjj

@EvenLjj EvenLjj force-pushed the support_chanage_grpc_maxInboundMessageSize branch from 8c4e696 to 0a7f6da Compare June 13, 2023 08:43
@sofastack-cla sofastack-cla bot added size/L and removed size/XS labels Jun 13, 2023
@EvenLjj EvenLjj force-pushed the support_chanage_grpc_maxInboundMessageSize branch from 0a7f6da to 2a764b5 Compare June 13, 2023 08:49
@EvenLjj
Copy link
Collaborator Author

EvenLjj commented Jun 13, 2023

  1. Test is needed to check the limited size.
  2. Do we need to set outbound size ?
    @EvenLjj

Fixed and supported. @OrezzerO

@EvenLjj EvenLjj requested a review from Lo1nt June 13, 2023 09:05
Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . Related issue can be found: grpc/grpc-java#2563

@EvenLjj EvenLjj merged commit 3338957 into sofastack:master Jun 14, 2023
3 checks passed
Lo1nt added a commit that referenced this pull request Jun 20, 2023
* Modify the parsing header method to facilitate expansion (#1325)

Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com>

* feat: let use of javassist compatible at jdk 17 (#1316)

Co-authored-by: junyuan <zhangminglun.zml@ant-group.com>

* upgrade rpc version to 5.10.0-SNAPSHOT (#1326)

* upgrade rpc version to 5.10.0-SNAPSHOT

* upgrade rpc version to 5.10.0-SNAPSHOT

---------

Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com>

* Custom serializer register (#1296)

* feat: use extension on serializer register
---------

Co-authored-by: 均源 <zhangminglun.zml@antgroup.com>
Co-authored-by: junyuan <zhangminglun.zml@ant-group.com>

* chore: update version to release (#1328)

Co-authored-by: lo1nt <zhangminglun.zml@ant-group.com>

* upgrade rpc version to 5.10.1-SNAPSHOT (#1334)

Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com>

* support change grpc maxInboundMessageSize (#1333)

Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com>

* Fix the unit test message too large problem (#1339)

* support change grpc maxInboundMessageSize

* fix the debug body message too large problem

---------

Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com>

* feat: bump hessian from 3.13.3 to 3.4.0 (#1338)

Co-authored-by: Lo1nt <zhangminglun.zml@antgroup.com>

* updapte 5.10.1 version to release (#1337)

Co-authored-by: Lo1nt <zhangminglun.zml@antgroup.com>

* update version

* bump hessian

* update version

* add ci

* set verison as 51100

* fix: destory

* fix: unit test

---------

Co-authored-by: evenliu <evenljj@163.com>
Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com>
Co-authored-by: lo1nt <zhangminglun.zml@ant-group.com>
Co-authored-by: lo1nt <zhangminglun.zml@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants