Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:error code #857

Merged
merged 2 commits into from
Feb 19, 2020
Merged

feat:error code #857

merged 2 commits into from
Feb 19, 2020

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Feb 19, 2020

Motivation:

同一错误码体系。#总共9位,大分类2,小分类3,具体错误4

按照

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@leizhiyuan leizhiyuan added this to the 5.6.5 milestone Feb 19, 2020
@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #857 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #857      +/-   ##
============================================
- Coverage     71.07%   71.05%   -0.02%     
- Complexity     1128     1129       +1     
============================================
  Files           381      381              
  Lines         15854    15854              
  Branches       2521     2521              
============================================
- Hits          11268    11265       -3     
- Misses         3276     3281       +5     
+ Partials       1310     1308       -2
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/alipay/sofa/rpc/log/LogCodes.java 53.57% <ø> (ø) 0 <0> (ø) ⬇️
...java/com/alipay/sofa/rpc/module/LookoutModule.java 52.38% <0%> (-33.34%) 3% <0%> (-1%)
...m/alipay/sofa/rpc/codec/jackson/JacksonHelper.java 77.77% <0%> (-2.78%) 7% <0%> (-1%)
.../main/java/com/alipay/sofa/rpc/event/EventBus.java 70.58% <0%> (-1.97%) 0% <0%> (ø)
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 87.65% <0%> (-1.24%) 0% <0%> (ø)
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java 75.51% <0%> (+1.02%) 25% <0%> (+1%) ⬆️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 82.14% <0%> (+1.78%) 0% <0%> (ø) ⬇️
...y/sofa/rpc/transport/grpc/GrpcClientTransport.java 67.5% <0%> (+2.5%) 14% <0%> (+1%) ⬆️
...pay/sofa/rpc/transport/ClientTransportFactory.java 76.92% <0%> (+4.61%) 0% <0%> (ø) ⬇️
...sian/MultipleClassLoaderSofaSerializerFactory.java 93.33% <0%> (+6.66%) 5% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2810b...b25fdfb. Read the comment docs.

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leizhiyuan leizhiyuan merged commit 2c8ec8c into master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants