Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复SQLException被吃掉的问题 #231

Closed
wants to merge 1 commit into from
Closed

修复SQLException被吃掉的问题 #231

wants to merge 1 commit into from

Conversation

moorefu
Copy link

@moorefu moorefu commented Jun 19, 2019

类com.alipay.sofa.tracer.plugins.datasource.Invocation的invoke方法未正确处理InvocationTargetException导致SQLException被吃掉。
加上该处理

@moorefu
修复SQLException被吃掉的问题
1df8c74 
invoke会抛出InvocationTargetException，此处调用未进行正确处理导致SQLException被吃掉。
glmapper
glmapper reviewed Jun 19, 2019
View reviewed changes
Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also fix the problem of the master branch at the same time.

@glmapper glmapper self-requested a review July 26, 2019 08:30
@glmapper
Copy link
Contributor

Combine to #236

@glmapper glmapper closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glmapper glmapper Awaiting requested review from glmapper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moorefu @glmapper