-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier session resume #41
Comments
Is this implicitly the same as reboot mode? If so, should we merge it with that issue? |
No, it's separate. The session may crash in non-reboot mode, and we need a way to continue without over-writing results. |
I should have said: is the code which picks up where we left off implicitly the same between the two modes? |
There will be sharing, yes. |
Sure. Go ahead. |
I imagine we need to flesh out the working of this feature too. When I raised this, I did not have the reboot mechanism in mind. |
OK, well your initial issue here suggests that If the results are not complete, and Each execution then needs to append to the JSON file, rather than writing the file out at the end of all the executions. Also, there is no need for a file in In this scheme, #54 just needs to have a script in Does that make sense? |
Yes, and I think this all sounds sensible. Go for it. |
Edited that slightly. |
This is separate, but I would also like a way to re-run a subset of experiments. Using the scheme you outline above, you can re-run stuff by deleting entries from the json bz2 file. This is quite fiddly as you have to uncompress and then locate the right lines to remove in a results file potentially with tens of thousands of lines, so I wonder if we could write a tiny tool to remove results by key. Thoughts? |
Note also that krun currently dumps a bz json file after each execution, not just once at the end. This is to protect against crashing. |
WRT: Does krun need to know if it's in reboot mode? I suggest adding a boolean config option |
OK, I think it would be helpful for testing this to add the |
What would you test? |
For now, I just mean that I need something to try out by hand. Potentially I'm sure there are other things that Travis could test, but I think that would be a separate PR / Issue. |
When a benchmark session crashes, or when the system loses power, we often need to run again just what we need to.
Currently this is quite a manual process. The experimenter has to manually determine which work needs to be run, run them, then manually merge the new data into the existing data.
It would be better if krun could help us do this.
I imagine something like the following:
partial results detected. Looks like we need to run: 4 executions of benchmark3 and 4 executions of benchmark 4, OK?
This need not be an interactive process, there could be a
-check-results
and a-resume
option on the CLI.The text was updated successfully, but these errors were encountered: