Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic travis config #69

Merged
merged 1 commit into from
Oct 22, 2015
Merged

Add basic travis config #69

merged 1 commit into from
Oct 22, 2015

Conversation

snim2
Copy link
Collaborator

@snim2 snim2 commented Oct 22, 2015

There are some tests in krun/tests/ which can be run with py.test, and some of the work for Issue #41 (such as appending to a JSON file) are testable.

This PR adds a travis config to run these tests automatically.

@snim2
Copy link
Collaborator Author

snim2 commented Oct 22, 2015

We need to turn travis on in the repo, and also the travis account needs to turn the repo on (if that makes sense). I'm not sure whether this github account already has a travis account?

@vext01
Copy link
Member

vext01 commented Oct 22, 2015

Are you happy to look into that?

@snim2
Copy link
Collaborator Author

snim2 commented Oct 22, 2015

I can do all that, but I think I need the password to this GH account, otherwise everything will end up being owned by snim2.

@vext01
Copy link
Member

vext01 commented Oct 22, 2015

I don't think there is an account for the team. Just admins for the team?

@snim2
Copy link
Collaborator Author

snim2 commented Oct 22, 2015

Hmm. OK, well I'll have a go, and if we aren't happy with the set up we can always change it later.

vext01 added a commit that referenced this pull request Oct 22, 2015
@vext01 vext01 merged commit 27d695f into master Oct 22, 2015
@vext01
Copy link
Member

vext01 commented Oct 22, 2015

Good luck!

@snim2
Copy link
Collaborator Author

snim2 commented Oct 22, 2015

OK, this seems to be fine: https://travis-ci.org/softdevteam/krun

@vext01
Copy link
Member

vext01 commented Oct 22, 2015

Nice! Well done.

@snim2 snim2 deleted the travis branch October 30, 2015 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants