Use typed arrays in Javascript runner. #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ah ha! We can actually used typed arrays in JavaScript since there is a
Float64Array. I've checked that both V8 and spidermonkey (only the former of which is part of the main experiment) support this, and they do.Tested using the warmup experiment running only V8 (we don't have an iterations running for spidermonkey).
Info about
Float64Arrayhere:https://blog.codingbox.io/exploring-javascript-typed-arrays-c8fd4f8bd24f
OK?
Fixes #382