This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Correct content type of response for image metadata getting api #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change [0] makes glanceclient use requests to communicate
with glance server, new http handling logic of which is sensitive on the
content type of response [1].
But current jumpgate logic for the api doesn't return any content by
http body [2] but with 'application/json' content type [3]. Then it
broken that new glanceclient logic and trigger error: "Multiple image
matches found for '<IMAGE_ID>', use an ID to be more specific.".
[0]
openstack/python-glanceclient@dbb242b
[1]
https://github.com/openstack/python-glanceclient/blob/master/glanceclient/common/http.py#L218
[2]
https://github.com/softlayer/jumpgate/blob/master/jumpgate/image/drivers/sl/images.py#L223
[3] https://github.com/racker/falcon/blob/master/falcon/__init__.py#L27
Signed-off-by: Zhi Yan Liu zhiyanl@cn.ibm.com