Don't automatically reauthenticate on 404 errors #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GET, HEAD, and DELETE were capturing any exception from the lower level operation and automatically reauthenticating before retrying. The intent is to catch expired authentication and transparently retry the operation. This is inefficient for querying files that don't exist on object storage as it will trigger the following flow: 1) GET/HEAD/DELETE is attempted on a non-existent object 2) The original request fails with an Http_NotFound exception 3) Reauthentication is performed against Object Storage 4) The original request is attempted again and the Http_NotFound exception is allow to propagate to the caller Handle this case by explicitly catching an Http_NotFound exception and rethrowing it at step #2 above
|
👍 (maybe adding tests around this would be nice though) ping @briancline |
|
Thanks for the reminder. Yeah, tests would be good for this. I'll go ahead and merge for now. Thank you for the patch! |
briancline
added a commit
that referenced
this pull request
Dec 10, 2014
Don't automatically reauthenticate on 404 errors
|
thanks for taking care of the pull requests! 🎉 |
|
Sure thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET, HEAD, and DELETE were capturing any exception from the lower level
operation and automatically reauthenticating before retrying. The intent
is to catch expired authentication and transparently retry the
operation.
This is inefficient for querying files that don't exist on object
storage as it will trigger the following flow:
exception is allow to propagate to the caller
Handle this case by explicitly catching an Http_NotFound exception and
rethrowing it at step #2 above