Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't automatically reauthenticate on 404 errors #20

Merged
merged 1 commit into from
Dec 10, 2014
Merged

Don't automatically reauthenticate on 404 errors #20

merged 1 commit into from
Dec 10, 2014

Commits on Sep 16, 2014

  1. Don't automatically reauthenticate on 404 errors 

    GET, HEAD, and DELETE were capturing any exception from the lower level
operation and automatically reauthenticating before retrying. The intent
is to catch expired authentication and transparently retry the
operation.

This is inefficient for querying files that don't exist on object
storage as it will trigger the following flow:

1) GET/HEAD/DELETE is attempted on a non-existent object
2) The original request fails with an Http_NotFound exception
3) Reauthentication is performed against Object Storage
4) The original request is attempted again and the Http_NotFound
   exception is allow to propagate to the caller

Handle this case by explicitly catching an Http_NotFound exception and
rethrowing it at step #2 above
    @etaoins
    etaoins committed Sep 16, 2014
    Configuration menu
    Copy the full SHA
    8613a24 View commit details
    Browse the repository at this point in the history