Add "connect_timeout" option for cURL. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancline
added a commit
that referenced
this pull request
Aug 12, 2015
Add "connect_timeout" option for cURL.
|
Sorry this took a while, apparently my email notifications aren't working. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
connect_timeoutoption. However, this currently affects cURL only.Zend's HTTP client apparently only has a connect timeout, not a timeout for an established link or the entire request, so using
connect_timeoutwould actually be more applicable than the existingtimeoutoption, but this is a semantic change, though not necessarily backwards-incompatible (we could preferconnect_timeoutif it is notNULLand fall back totimeoutotherwise).PHP's
fsockopen()'s$timeoutparameter also refers to a connection timeout rather than a request timeout, which can be specified withstream_set_timeout.