Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arbitrary CURL options, or at least for connect timeout option #28

Open
theage opened this issue Apr 22, 2015 · 1 comment

Comments

@theage
Copy link
Contributor

theage commented Apr 22, 2015

Please provide a way to set arbitrary CURL options, or at least all timeout settings.

When trying to load large objects, the request may time out.
To work around this, you can set the timeout for the entire request to a few minutes maybe.

However this may cause your downloads to wait for a very long time if there are connection issues, because CURL defaults to very high timeout values e.g. for the connect phase (5 minutes), which you may not want.

Looking at the source of ObjectStorage_Http_Adapter_Curl, it seems that there are only a few hard-coded CURL options that can be set at all.

Rather than hard-code yet another option, I think it would be better to just provide a generic way to set any CURL option, e.g. via an array curloptions in the $options argument to the ObjectStorage constructor.

@theage
Copy link
Contributor Author

theage commented Aug 6, 2015

PR #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant