Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Ordering Manager verify_quote() method. #1430

Closed
ATGE opened this issue Mar 2, 2021 · 0 comments · Fixed by #1431
Closed

Refactor Ordering Manager verify_quote() method. #1430

ATGE opened this issue Mar 2, 2021 · 0 comments · Fixed by #1431
Assignees
@ATGE
Labels
Bug

Comments

@ATGE
Copy link
Contributor

ATGE commented Mar 2, 2021

The problem
There are a few fields that cause exceptions when we use the Rest endpoint because we are retrieving and sending fields as None values.

TODO
Refactor Ordering Manager verify_quote() method to clean all empty string or None fields just to be safe before sending the call API request
@ATGE ATGE added the Bug label Mar 2, 2021
@ATGE ATGE self-assigned this Mar 2, 2021
ATGE added a commit to ATGE/softlayer-python that referenced this issue Mar 2, 2021
@ATGE
softlayer#1430 refactor Ordering verify_quote cleaning empty or None …
fb138c6 
…fields logic
@ATGE ATGE mentioned this issue Mar 2, 2021
Merged
@allmightyspiff allmightyspiff linked a pull request Mar 12, 2021 that will close this issue
Refactor Ordering verify_quote method #1431
Merged
@allmightyspiff allmightyspiff mentioned this issue Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ATGE ATGE

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Ordering verify_quote method ATGE/softlayer-python
1 participant
@ATGE