Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Ordering verify_quote method #1431

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Refactor Ordering verify_quote method #1431

merged 1 commit into from
Mar 12, 2021

Conversation

ATGE
Copy link
Contributor

@ATGE ATGE commented Mar 2, 2021

@ATGE ATGE requested a review from allmightyspiff March 2, 2021 22:38
@ATGE ATGE self-assigned this Mar 2, 2021
@ATGE ATGE requested a review from caberos March 2, 2021 22:45
@allmightyspiff allmightyspiff added the Ordering Anything related to ordering label Mar 3, 2021
@allmightyspiff allmightyspiff added this to In progress in Q1 2021 via automation Mar 3, 2021
caberos
caberos approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@caberos caberos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allmightyspiff allmightyspiff linked an issue Mar 12, 2021 that may be closed by this pull request
Refactor Ordering Manager verify_quote() method. #1430
Closed
@allmightyspiff allmightyspiff merged commit 62cbfbd into softlayer:master Mar 12, 2021
Q1 2021 automation moved this from In progress to Done Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@caberos caberos caberos approved these changes

Assignees

@ATGE ATGE

Labels
Ordering Anything related to ordering
Projects
No open projects
Q1 2021
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Ordering Manager verify_quote() method.
3 participants
@ATGE @allmightyspiff @caberos