Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When listing datacenters/pods, mark those that are closing soon. #1597

Merged
merged 8 commits into from
Mar 24, 2022
Merged

When listing datacenters/pods, mark those that are closing soon. #1597

merged 8 commits into from
Mar 24, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Mar 21, 2022

allmightyspiff
allmightyspiff requested changes Mar 21, 2022
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes and this should be good to go, thanks.

SoftLayer/CLI/hardware/create_options.py Outdated Show resolved Hide resolved
SoftLayer/CLI/virt/create_options.py Outdated Show resolved Hide resolved
SoftLayer/managers/network.py Outdated Show resolved Hide resolved
SoftLayer/CLI/hardware/create_options.py Outdated Show resolved Hide resolved
SoftLayer/CLI/hardware/create_options.py Outdated Show resolved Hide resolved
@edsonarios
Copy link
Contributor

Screenshots of the test
image
image

Missing Notes field in this command
image

The another 2 commands it's works very well

@edsonarios
Copy link
Contributor

image

allmightyspiff
allmightyspiff requested changes Mar 24, 2022
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix this unit test and this is good to go, thanks

tests/CLI/modules/order_tests.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff linked an issue Mar 24, 2022 that may be closed by this pull request
When listing datacenters/pods, mark those that are closing soon. #1589
Closed
@allmightyspiff allmightyspiff merged commit 51b594e into softlayer:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsonarios edsonarios edsonarios left review comments

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@caberos caberos

Labels
CLI
Projects
No open projects
Q12022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When listing datacenters/pods, mark those that are closing soon.
3 participants
@caberos @edsonarios @allmightyspiff