Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the block volume-options command #1681

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Jul 4, 2022

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature, I was just thinking we needed something like it :)

  1. All these size/iops values need to come from the API. I think the STORAGE_AS_A_SERVICE_STAAS package has all the needed details. I dont want any of these values to be hard coded if we can avoid it, since different accounts have different options sometimes.
  2. Datacenters should be its own table, like slcli vs create-options with the "closing soon" remarks.
  3. "IOPS" table doesn't need a size row since those are already in the column headers.
  4. That knowledgelayer.softlayer.com link doesn't work (that domain is dead).

(these can be handled in new issues)
6. A --prices flag would be a good addition
7. If possible, flag "next generation" datacenters somehow? . I know some Datacenters allow encryption at rest, which is important to indicate. https://cloud.ibm.com/docs/BlockStorage?topic=BlockStorage-selectDC Like these 2 with the star on the order page.
image

@allmightyspiff allmightyspiff linked an issue Jul 12, 2022 that may be closed by this pull request
@allmightyspiff allmightyspiff merged commit cdf590a into softlayer:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add the block volume-options command
2 participants