Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block/file volume-options improvement 3 #1705

Merged
merged 6 commits into from
Jul 29, 2022
Merged

block/file volume-options improvement 3 #1705

merged 6 commits into from
Jul 29, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Jul 22, 2022

@edsonarios
Copy link
Contributor

Screenshots of the test result
Block
image
File
image

Maybe there should be a validator when I put a location that doesn't exist
image

@allmightyspiff allmightyspiff added CLI Storage Storage Systems labels Jul 25, 2022
@allmightyspiff allmightyspiff linked an issue Jul 25, 2022 that may be closed by this pull request
block|file volume-options improvements 3 #1694
Closed
edsonarios
edsonarios approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allmightyspiff allmightyspiff merged commit 3b517cb into softlayer:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@edsonarios edsonarios edsonarios approved these changes

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@caberos caberos

Labels
CLI Storage Storage Systems
Projects
No open projects
Q3 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

block|file volume-options improvements 3
3 participants
@caberos @edsonarios @allmightyspiff