Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slcli vlan list only returns 100 results #1852

Merged
merged 2 commits into from
Feb 7, 2023
Merged

slcli vlan list only returns 100 results #1852

merged 2 commits into from
Feb 7, 2023

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Feb 3, 2023

allmightyspiff
allmightyspiff requested changes Feb 3, 2023
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this issue is to make sure slcli vlan list ALWAYS prints all vlans.

SoftLayer/managers/network.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff linked an issue Feb 3, 2023 that may be closed by this pull request
slcli vlan list only returns 100 results #1851
Closed
@edsonarios
Copy link
Contributor

Screenshot of the test result
image

edsonarios
edsonarios approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment, looks good to me

@allmightyspiff allmightyspiff merged commit 84329fc into softlayer:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@edsonarios edsonarios edsonarios approved these changes

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@caberos caberos

Labels
Bug
Projects
No open projects
Q1 2023
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slcli vlan list only returns 100 results
3 participants
@caberos @edsonarios @allmightyspiff