Clarify CCI transaction output #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename the "provisioning" column to "active_transaction" It's slightly more accurate, and it's just a preference of mine not to introduce new terminology. If users interact with the API in other ways, it'll be called a transaction, right? Or is the terminology changing globally? * Display "<None>" for an empty active transaction The empty string means that transaction would always have to be the last column, because you couldn't count on awk column offsets in selecting individual fields. Also, it makes it hard to grep for CCI that _don't_ currently have an active transaction.
|
Manually resolved and pushed. Closing merge request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's slightly more accurate, and it's just a preference of mine not to
introduce new terminology. If users interact with the API in other ways,
it'll be called a transaction, right? Or is the terminology changing
globally?
The empty string means that transaction would always have to be the last
column, because you couldn't count on awk column offsets in selecting
individual fields. Also, it makes it hard to grep for CCI that don't
currently have an active transaction.