Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple profiles #134

Merged

Conversation

smcavallo
Copy link
Contributor

Allow multiple profiles to exist in the softlayer credential file.
The current implementation only allows one set of creds under a key of ['softlayer']

Proposed implementation allows multiple sets of credentials in the file using an environment variable of "SL_PROFILE" to determine which set to use. This is a standard pattern with credential files and ruby sdks.
This allows credentials for multiple environments to be stored in the same file.

@coveralls
Copy link

coveralls commented Mar 29, 2018

Coverage Status

Coverage increased (+0.004%) to 99.767% when pulling 06e2a3a on smcavallo:support_multiple_profiles into 7889052 on softlayer:master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 29, 2018

Coverage Status

Coverage increased (+0.004%) to 99.767% when pulling 06e2a3a on smcavallo:support_multiple_profiles into 7889052 on softlayer:master.

@smcavallo
Copy link
Contributor Author

@SLsthompson - looking for a review and for a new version of the softlayer_api gem to be published to rubygems

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Although Piglet's api_key should be something like "Oh, d-d-d-dear!" :)

@allmightyspiff allmightyspiff merged commit c93a234 into softlayer:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants