Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: make body an Option #107

Merged
merged 1 commit into from
Feb 3, 2018
Merged

Issue: make body an Option #107

merged 1 commit into from
Feb 3, 2018

Conversation

grahamc
Copy link
Contributor

@grahamc grahamc commented Feb 2, 2018

A PR with absolutely no body causes errors with decoding, because GitHub sends a null body:

  pull_request: {
    url: https://api.github.com/repos/NixOS/nixpkgs/pulls/34454,
    html_url: https://github.com/NixOS/nixpkgs/pull/34454,
    diff_url: https://github.com/NixOS/nixpkgs/pull/34454.diff,
    patch_url: https://github.com/NixOS/nixpkgs/pull/34454.patch
  },
  body: null,
  closed_by: null

A PR with absolutely no body causes errors with decoding, because GitHub sends a null body:

  pull_request: {
    url: https://api.github.com/repos/NixOS/nixpkgs/pulls/34454,
    html_url: NixOS/nixpkgs#34454,
    diff_url: https://github.com/NixOS/nixpkgs/pull/34454.diff,
    patch_url: https://github.com/NixOS/nixpkgs/pull/34454.patch
  },
  body: null,
  closed_by: null
@softprops
Copy link
Owner

Thanks. I'll try to publish a release this weekend

@softprops
Copy link
Owner

Looks like Travis is failing of rust beta but not because of this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants