Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A PR with absolutely no body causes errors in hubcaps #46

Closed
grahamc opened this issue Jan 29, 2018 · 2 comments
Closed

A PR with absolutely no body causes errors in hubcaps #46

grahamc opened this issue Jan 29, 2018 · 2 comments

Comments

@grahamc
Copy link
Member

grahamc commented Jan 29, 2018

NixOS/nixpkgs#34372 had no body, and hubcaps couldn't handle this, and would return an Err when trying to parse the issue.

@grahamc
Copy link
Member Author

grahamc commented Feb 2, 2018

This came up again:

{
  "url": "https://api.github.com/repos/NixOS/nixpkgs/issues/34454",
  "repository_url": "https://api.github.com/repos/NixOS/nixpkgs",
  "labels_url": "https://api.github.com/repos/NixOS/nixpkgs/issues/34454/labels{/name}",
  "comments_url": "https://api.github.com/repos/NixOS/nixpkgs/issues/34454/comments",
  "events_url": "https://api.github.com/repos/NixOS/nixpkgs/issues/34454/events",
  "html_url": "https://github.com/NixOS/nixpkgs/pull/34454",
  "id": 293150228,
  "number": 34454,
  "title": "cups-filters: 1.16.0 -> 1.20.0",
  "user": {
    "login": "layus",
    "id": 632767,
    "avatar_url": "https://avatars3.githubusercontent.com/u/632767?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/layus",
    "html_url": "https://github.com/layus",
    "followers_url": "https://api.github.com/users/layus/followers",
    "following_url": "https://api.github.com/users/layus/following{/other_user}",
    "gists_url": "https://api.github.com/users/layus/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/layus/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/layus/subscriptions",
    "organizations_url": "https://api.github.com/users/layus/orgs",
    "repos_url": "https://api.github.com/users/layus/repos",
    "events_url": "https://api.github.com/users/layus/events{/privacy}",
    "received_events_url": "https://api.github.com/users/layus/received_events",
    "type": "User",
    "site_admin": false
  },
  "labels": [

  ],
  "state": "open",
  "locked": false,
  "assignee": null,
  "assignees": [

  ],
  "milestone": null,
  "comments": 3,
  "created_at": "2018-01-31T13:03:25Z",
  "updated_at": "2018-02-02T02:23:59Z",
  "closed_at": null,
  "author_association": "CONTRIBUTOR",
  "pull_request": {
    "url": "https://api.github.com/repos/NixOS/nixpkgs/pulls/34454",
    "html_url": "https://github.com/NixOS/nixpkgs/pull/34454",
    "diff_url": "https://github.com/NixOS/nixpkgs/pull/34454.diff",
    "patch_url": "https://github.com/NixOS/nixpkgs/pull/34454.patch"
  },
  "body": null,
  "closed_by": null
}

@grahamc
Copy link
Member Author

grahamc commented Feb 2, 2018

I sent a PR upstream softprops/hubcaps#107

@grahamc grahamc closed this as completed in e62a62c Feb 2, 2018
grahamc added a commit that referenced this issue Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant