Fix flash when showing dialog #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakub-gonet is attempting to deploy a commit to the software-mansion Team on Vercel. To accomplish this, @jakub-gonet needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
kmagiera
reviewed
Apr 12, 2024
filip131311
pushed a commit
that referenced
this pull request
Apr 15, 2024
Screen behind was flashing due to the fact that devices manager reloaded listed devices which triggered rendering loading component in PreviewView. Also simplified code in CreateDeviceView and pulled out useEffect from useDevice – it was used in two places only. Fixes #63 https://github.com/software-mansion/react-native-ide/assets/12465392/3b30d93f-f643-4ac3-94c7-00f7935ee873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen behind was flashing due to the fact that devices manager reloaded listed devices which triggered rendering loading component in PreviewView.
Also simplified code in CreateDeviceView and pulled out useEffect from useDevice – it was used in two places only.
Fixes #63
noflash.mov