Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect links and whitespace in docs #1018

Merged

Conversation

shirohana
Copy link
Contributor

I found a typo in the doc, it caused the docs site generates an invalid link.

I fixed that and also take a look in docs, and modify some indents and newlines for keeping the doc looks consistently (๑ơ ω ơ)

docs/about-handlers.md

  ...
  Gesture handler library exposes a set of components normally available in React Native that 
- are wrapped in [`NativeViewGestureHandler`](handler-native.md).
+ are wrapped in [`NativeViewGestureHandler`](handlers.md).

This was linked to issues Jul 13, 2020
Copy link
Member

@jakub-gonet jakub-gonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉

I'm not sure if native-handler.md should be changed to handlers.md, but I think we can redirect it there for now.

Co-authored-by: Muhammad Ali <mr.muhammad.ali@live.com>
@jakub-gonet jakub-gonet mentioned this pull request Jul 13, 2020
@jakub-gonet jakub-gonet changed the title Fix incorrect links and some miscellaneous in docs Fix incorrect links and whitespace in docs Jul 13, 2020
@jakub-gonet jakub-gonet merged commit 8cf2214 into software-mansion:master Jul 13, 2020
@shirohana shirohana deleted the fix/docs-incorrect-links branch July 15, 2020 03:18
braincore pushed a commit to braincore/react-native-gesture-handler that referenced this pull request Mar 4, 2021
Co-authored-by: Muhammad Ali <mr.muhammad.ali@live.com>
Co-authored-by: Jakub <jakub.gonet@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official website link 404 NativeViewGestureHandler docs
2 participants