Restore eslint rule to prefer import type (#4938)

<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

Thanks to @bartlomiejbloniarz who noticed it, the rule was (iirc)
accidentally removed in #4672.

## Test plan

🧨

.eslintrc.js

@@ -37,5 +37,9 @@ module.exports = {
     // '@typescript-eslint/no-duplicate-type-constituents': 'error', // TODO this currently breaks ESLint for VSCode in plugin
     eqeqeq: 'error',
     'no-unreachable': 'error',
+    '@typescript-eslint/consistent-type-imports': [
+      'error',
+      { prefer: 'type-imports' },
+    ],
   },
 };

plugin/src/buildWorkletString.ts

@@ -29,7 +29,7 @@ import { strict as assert } from 'assert';
 import * as convertSourceMap from 'convert-source-map';
 import * as fs from 'fs';
 import { isRelease } from './utils';
-import { WorkletizableFunction } from './types';
+import type { WorkletizableFunction } from './types';
 
 const MOCK_SOURCE_MAP = 'mock source map';
 

plugin/src/isGestureHandlerEventCallback.ts

@@ -6,7 +6,7 @@ import {
   isMemberExpression,
   isExpression,
 } from '@babel/types';
-import { ExplicitWorklet } from './types';
+import type { ExplicitWorklet } from './types';
 
 const gestureHandlerGestureObjects = new Set([
   // from https://github.com/software-mansion/react-native-gesture-handler/blob/new-api/src/handlers/gestures/gestureObjects.ts

plugin/src/types.ts

@@ -1,5 +1,5 @@
-import { BabelFile } from '@babel/core';
-import {
+import type { BabelFile } from '@babel/core';
+import type {
   FunctionDeclaration,
   FunctionExpression,
   ObjectMethod,

src/JSPropUpdater.ts

@@ -4,7 +4,7 @@ import {
   findNodeHandle,
 } from 'react-native';
 import { nativeShouldBeMock } from './reanimated2/PlatformChecker';
-import { StyleProps } from './reanimated2';
+import type { StyleProps } from './reanimated2';
 
 interface ListenerData {
   viewTag: number;

src/reanimated2/Colors.ts

@@ -6,7 +6,7 @@
  */
 
 /* eslint no-bitwise: 0 */
-import { StyleProps } from './commonTypes';
+import type { StyleProps } from './commonTypes';
 import { makeShareable } from './core';
 import { isAndroid, isWeb } from './PlatformChecker';
 

src/reanimated2/NativeMethods.ts

@@ -1,4 +1,4 @@
-import { MeasuredDimensions, ShadowNodeWrapper } from './commonTypes';
+import type { MeasuredDimensions, ShadowNodeWrapper } from './commonTypes';
 import {
   isChromeDebugger,
   isJest,

src/reanimated2/SetNativeProps.ts

@@ -1,4 +1,4 @@
-import { ShadowNodeWrapper, StyleProps } from './commonTypes';
+import type { ShadowNodeWrapper, StyleProps } from './commonTypes';
 import {
   isChromeDebugger,
   isJest,

src/reanimated2/animation/util.ts

@@ -1,4 +1,4 @@
-import { HigherOrderAnimation, StyleLayoutAnimation } from './commonTypes';
+import type { HigherOrderAnimation, StyleLayoutAnimation } from './commonTypes';
 import type { ParsedColorArray } from '../Colors';
 import {
   isColor,
@@ -17,9 +17,11 @@ import {
   ReduceMotion,
 } from '../commonTypes';
 import NativeReanimatedModule from '../NativeReanimated';
-import {
+import type {
   AffineMatrixFlat,
   AffineMatrix,
+} from './transformationMatrix/matrixUtils';
+import {
   flatten,
   multiplyMatrices,
   scaleMatrix,